Skip to content

Fix JDBC driver class loading and Testcontainers support #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

Fix JDBC driver class loading and Testcontainers support #228

merged 2 commits into from
Jun 27, 2025

Conversation

@nakamura-to
Copy link
Member

@nakamura-to nakamura-to commented Jun 27, 2025

Summary

  • Add automatic JDBC driver inference for Testcontainers URLs
  • Fix class loader issues by wrapping JDBC drivers with proper context switching
  • Update tests to validate Testcontainers driver inference

Changes

  1. JdbcUtil: Added logic to automatically infer the correct JDBC driver class name for Testcontainers URLs (e.g., jdbc:tc:mysql:/// → com.mysql.cj.jdbc.Driver)
  2. DriverWrapper: New class that wraps JDBC drivers to ensure all operations execute with the correct class loader context, preventing ClassNotFoundException issues
  3. CodeGenConfig: Updated to use DriverWrapper when creating data sources

Test plan

  • Unit tests pass for JdbcUtil driver inference
  • Integration tests with actual Testcontainers URLs work correctly
  • No regression in existing JDBC driver functionality

🤖 Generated with Claude Code

nakamura-to and others added 2 commits June 28, 2025 06:19
@nakamura-to @claude
Support Testcontainers driver inference in JdbcUtil
acbf3e6 
When a JDBC URL contains the Testcontainers prefix (tc:), return
org.testcontainers.jdbc.ContainerDatabaseDriver as the driver class.
This enables automatic driver detection for Testcontainers-based
database connections.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@nakamura-to @claude
Fix class loader issues with JDBC drivers
5ac6fbd 
Wrap JDBC drivers to ensure proper class loader context switching when
executing driver operations. This prevents ClassNotFoundException and
other class loading issues when the driver and plugin are loaded by
different class loaders.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@github-actions github-actions bot added the fix label Jun 27, 2025
@nakamura-to nakamura-to merged commit 2d4b168 into master Jun 27, 2025
2 checks passed
@nakamura-to nakamura-to deleted the fix/infer-jdbc-driver-for-tc branch June 27, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nakamura-to